https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38461
--- Comment #67 from Tomás Cohen Arazi (tcohen) <tomasco...@gmail.com> --- Created attachment 182697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182697&action=edit [24.11.x] Bug 38461: (follow-up) Fix tests This patch does two things: * Fixes a backport issue with 38461, making `mock_table_settings` have the right function signature, and accept (and use) the `table_settings_var` parameter. * Makes the scope for the `items_table_settings` variable be the window object, so it is accessible to Cypress for manipulation/mocking. This is done by changing `let` for `var` [1] To test: 1. Run: $ ktd --shell k$ run_cypress --spec t/cypress/integration/KohaTable_spec.ts => FAIL: Tests fail! 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests pass! 4. Sign off :-D [1] If you are curious about it, change it back to `let` and run the tests. Signed-off-by: Tomas Cohen Arazi <tomasco...@theke.io> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
