https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23269
Johanna Räisä <johanna.ra...@koha-suomi.fi> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Needs Signoff
--- Comment #24 from Johanna Räisä <johanna.ra...@koha-suomi.fi> ---
(In reply to Pedro Amorim from comment #20)
> Hi Johanna, thank you for your patience here.
> I've rebased and tidied the patch on top of bug 38664. I believe the
> integrity of the patch was kept but apologies in advance if some regression
> was introduced here, my intention is to help move this forward.
> Here are my notes:
>
> Previously mentioned regressions that are still occurring (but not critical):
> 1) Setting an expiration date still triggers 2 pairs of API requests (the
> update + table rerender)
> 2) The button label for a suspended hold is "Resume", previously was
> "Unsuspend".
I made fixes to these. Those should be ok now.
>
> New regressions (worth investigating):
> 1) Before, if a hold is "in transit" (found = T), the priority column shows
> a disabled dropdown with value 'In transit'. Now, the dropdown contains 'In
> transit' but it's not disabled. Changing the value here for a hold triggers
> a table re-render but seemingly doesn't update any value.
For some reason I didn't notice this. I compared to current main and both were
disabled.
> 2) Table columns were sortable before, they are no longer. This may be
> tricky but if at least some of them are easy to make sortable we should
> consider this.
I added sortable to columns were it would make sense.
>
> Observation (not critical)
> The table now shows:
> Showing 1 to 4 of 4 entries (filtered from 5 total entries)
>
> This is the standard behavior of API based tables. But the '5' from the
> above example is referring to the total holds number of the database.I
> wonder if it will ever be relevant to show the total number of holds in the
> database in this screen? Provided patch if you agree.
This was a good addition. It looked a bit silly there.
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
