https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37870
--- Comment #19 from Jonathan Druart <jonathan.dru...@gmail.com> ---
(In reply to Jonathan Druart from comment #18)
> (In reply to Andrii Nugged from comment #17)
> > commit: "Bug 37870: Remove warning if biblionumber is not passed" has:
> >
> > ```
> > if ( exists $self->{biblionumber} ) {
> > $self->{biblionumber} = $params->{biblionumber} =~ s/\D//gr;
> > ```
> >
> > why `exists`, instead of `defined`?
> > it is called from cataloguing/addbiblio.pl:
> >
> > my $biblio_form_builder = Koha::UI::Form::Builder::Biblio->new(
> > {
> > biblionumber => scalar $input->param('biblionumber'),
> > }
> > );
> >
> > so on adding new biblio it produces warning:
> >
> > [2025/05/25 05:11:02] [WARN] Use of uninitialized value in substitution
> > (s///)
> > at /usr/share/koha/lib/Koha/UI/Form/Builder/Biblio.pm line 55.
> > from /usr/share/koha/intranet/cgi-bin/cataloguing/addbiblio.pl:277
> > from /usr/share/koha/intranet/cgi-bin/cataloguing/addbiblio.pl:888
> > PAGE GENERATED 200:
> > GET: /intranet/cataloguing/addbiblio.pl?frameworkcode=FA
>
> Well, the main problem I'd say is that $self->{biblionumber} actually never
> exists!
Sorry forget that, we have a follow-up in main (replacing "$self" with
"$params")
Bug 39462: (bug 37870 follow-up) Default values from framework are inserted
into existing record while editing
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
