https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34157

David Nind <da...@davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |da...@davidnind.com
           Assignee|cnighswon...@foundations.ed |hammat.w...@inlibro.com
                   |u                           |
  Text to go in the|                            |This fixes the "Error
      release notes|                            |500..." message generated
                   |                            |when printing barcode
                   |                            |ranges using the label
                   |                            |creator, and where the
                   |                            |layout type selected is
                   |                            |"Bibliographic data
                   |                            |precedes barcode"
                   |                            |(Cataloging > Tools > Label
                   |                            |creator).

--- Comment #14 from David Nind <da...@davidnind.com> ---
I had a go at testing. The patch still applies.

As I understand it, this bug fixes the error 500 if you use the "Bibliographic
data precedes barcode" layout type when printing a barcode range.

I'm happy to sign off, however the QA script complains:

 FAI    C4/Labels/Label.pm
   FAIL   tidiness
                 File is not tidy, please run `perl misc/devel/tidy.pl
C4/Labels/Label.pm`

The commit messages also need to follow the commit message guidelines
https://wiki.koha-community.org/wiki/Commit_messages

I also changed the assignee.

Testing notes (using KTD):
1. Set up information for testing:
   1.1 Create a new label layout:
       1.1.1 Cataloging > Tools > Label creator
       1.1.2 New > Label layout
       1.1.3 Add these details:
             - Layout name: BZ34157
             - Choose layout type: Bibliographic data precedes barcode
             - Select 'List fieds'
             - Data fields: add some text at the end
                title, author, isbn, issn, itemtype, barcode, itemcallnumber,
'Some text'
       1.1.3 Save
   1.2 Ranges of barcode numbers for testing:
       1.2.1 Where the numbers are not used in KTD, and are LOWER than the
highest barcode number (39999000019193): 500000 to 500100
       1.2.3 Where the numbers are not used in KTD, and are HIGHER than the
highest barcode number (39999000019193): 39999000020000 to 39999000020100
       1.2.2 Where the numbers are used in KTD: 3999900000001 to 3999900001001
2. Print a barcode range using the ranges in 1.2: 
   2.1 Cataloging > Tools > Label creator > Print barcode range
   2.2 Enter the barcode ranges
   2.3 Select a layout to be applied: BZ34157
   2.4 Export
   2.5 Click "Download as PDF"
   2.6 Results for all barcode ranges: 
       ==> You get a page with "An error has occured! Error 500...".
3. Repeat step 2, but select the DEFAULT layout for 2.3:
   ==> Results for all barcode ranges: PDFs with barcode labels successfully
generated
4. Apply the patches and restart everything (restart_all)
5. Repeat steps 2 and 3.
6. Results for all barcode ranges and the BZ34157 and DEFAULT layouts:
   ==> PDFs with barcode labels successfully generated

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to