https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40275
--- Comment #24 from David Cook <[email protected]> --- (In reply to Tomás Cohen Arazi (tcohen) from comment #23) > This patch set addresses a pattern that we use in the codebase and creates a > fully tested method for reusing it. Definitely a good move forward. > As with many places in Koha, old code that's been patched for years hides > bugs, and small refactoring intentions end up being a pain because 'why not > fix it all'. > > I agree and have always tried to fix all the things, but let's make it a > separate bug report. I would like to work on that, but it is better to have > a well summarized description of the problem to be solved. And some places > are so tricky we should probably have an individual bug for them. Agreed about making separate bug reports. Trying to fix all the things at once rarely works. Just want to make sure all the key people know there are other bug reports to consider. > In the case of `check_cookie_auth`, I'd say that fallback mechanism is > hiding another bug somewhere else. Because it was probably added as a > workaround. As we should really just have the borrowernumber there... so a > longer conversation that should happen in a separate report. Thanks Kyle > anyway! +1 > Setting this back to SO so we can move forward. > > Can someone file a follow-up bug in which we can discuss the other issues? > Happy to work on them! I've raised bug 40457 and I'll try to attach all related reports I know about -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
