https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42444
--- Comment #2 from Tomás Cohen Arazi (tcohen) <[email protected]> --- Created attachment 198915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198915&action=edit Bug 42444: Add missing embeds for waiting holds page The waiting holds page (waitingreserves.pl) needs data that is not currently exposed through the holds API embeds. This patch adds: - desk: the desk object (name) for holds assigned to a desk - item+strings: item with string representations (library names, location descriptions, item type labels) - cancellation_requests: the actual cancellation request objects with creation_date (the existing cancellation_requested embed only returns a boolean) - patron.notice_email_address: the computed email address used for notices (respects EmailFieldPrimary syspref). Also added as a direct embed on GET /patrons and GET /patrons/{patron_id}. All underlying relationships and methods already exist in Koha::Hold, Koha::Patron, and the DBIC schema. This patch only adds them to the OpenAPI specification enum lists. Test plan: 1. Apply patch 2. Run: $ ktd --shell k$ prove xt/api.t t/db_dependent/api/v1/holds.t => SUCCESS: Tests pass! 3. Verify the new embeds work: GET /api/v1/holds?status=W x-koha-embed: desk,item+strings,cancellation_requests,patron,patron.notice_email_address => SUCCESS: Response includes desk, item with _strings, cancellation_requests array, and patron with notice_email_address field 4. Sign off :-D Assisted-by: Sonnet 4.6 (Anthropic) -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
