https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503
--- Comment #19 from Tomás Cohen Arazi (tcohen) <[email protected]> --- Hi Pedro! Thanks for the valuable feedback! (In reply to Pedro Amorim (ammopt) from comment #17) > 1) There is an extra closing bracket in view_holdsqueue.tt preventing the > table from rendering at all, had to make the following to test further: > > @@ -392,7 +392,6 @@ > if (!row.patron || !row.patron.category) > return ""; > return (row.patron.category.name || > "").escapeHtml() + " (" + (row.patron.category_id || "").escapeHtml() + ")"; > }, > - }, > }, > { I think I messed up with several submissions because of submitting from the wrong worktree! Thanks for pointing this out. I'll take a closer look at my workflow! I've been testing this and didn't notice it. > 2) HidePatronName sys pref support is gone. Test before and after applying > patches, with HidePatronName enabled and disabled. Notice that patron name > is displayed in accordance to HidePatronName before the patches, but always > shows after the patches, completely ignoring the sys pref. I didn't really think about the syspref. This will be very tricky. > 3) Before, one of the following labels would show on the barcode column: > - Only item: <barcode> > - <barcode> or any item from item group > - <barcode> or any available > > But now, the item group case (2nd) is gone entirely. > > To test, apply only the sample data script patch + my follow-up and run: > cd /kohadevbox/koha && perl t/lib/sample_holds_queue.pl > > Ensure 'or any item from item group' exists on the holds queue page when > loading all 40 for All libraries. > Apply all patches, run: > $ yarn api:bundle > $ koha-plack --restart kohadev. > > Notice the 'or any item from item group' is gone. Thanks, I'll add the relevant embeds for this. > 4) The old table had per-column text filter inputs in the header row — those > are gone, replaced by sidebar-only filtering. Loss of functionality. Not > major but worth flagging. Will add it back, thanks! > 5) encodeURIComponent on the mailto href will encode @ to %40, producing > broken mailto links. > Hover over any email address on the patron column. Notice the produced > mailto link is e.g. 'patron1%40example.com'. Hm, taking a look! Thanks! -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
