Gregory Haskins wrote:
>>> diff -- git a/qemu/qemu- kvm.c b/qemu/qemu- kvm.c
>>> index 59e79bf..6096f21 100644
>>> --- a/qemu/qemu- kvm.c
>>> +++ b/qemu/qemu- kvm.c
>>> @@ - 697,6 +697,25 @@ int kvm_qemu_init()
>>> int kvm_qemu_create_context(void)
>>> {
>>> int i;
>>> + uint64_t ext;
>>> +
>>> + if (kvm_check_extension(kvm_context, &ext) < 0) {
>>> + kvm_qemu_destroy();
>>> + return - 1;
>>> + }
>>> +
>>> + if (!(ext & KVM_EXTENSION_LAPIC) && kvm_apic_level) {
>>> + /*
>>> + * Opps... the kernel doesnt support apic- emulation even though
>>> + * the user wants it. We must turn this off and warn the user
>>> + */
>>> + kvm_apic_level = 0;
>>> +
>>> + /* FIXME: We should log this officially */
>>> + printf("WARNING: older kernel does not support apic " \
>>> + "emulation. Falling back to userspace emulation. Upgrade " \
>>> + "your kernel/modules\n");
>>> + }
>>>
>>>
>> The user may not be in a position to upgrade the kernel. Think distro
>> kernel and userspace. A warning is a bit severe.
>>
>
> Ack. Should I drop the printf all together? Or just get rid of the
> "WARNING" and "please upgrade" part?. Also, is there a better way to log in
> this thing (instead of to stdout?)
>
Maybe only display it if the user specified the apic level option on the
qemu command line. It's a bit messy, but will be useful once the bug
reports start to flow in.
--
error compiling committee.c: too many arguments to function
-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
kvm-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/kvm-devel
