Change 20090727-maxcarlson-U by [email protected] on 2009-07-27 16:21:22 PDT in /Users/maxcarlson/openlaszlo/trunk-clean for http://svn.openlaszlo.org/openlaszlo/trunk
Summary: UPDATED AGAIN AGAIN: Don't re-parent input text to click tree Bugs Fixed: LPP-5447 DHTML: inputtext and clickable Technical Reviewer: ptw (pending) QA Reviewer: [email protected] (pending) Details: This is based on Tucker's change (http://svn.openlaszlo.org/openlaszlo/patches/20090722-ptw-k.tar ). I turned off the dom_breaks_focus quirk for firefox, cleaned up LzMouseKernel to not attempt to re-focus inputtexts when showing the click tree again. I had to resort to the istextsprite hack - ! this instanceof LzTextSprite wasn't working - not sure why :(. Finally, I test the target of global onmousemove events, and if it's not an inputtext and one's showing, I hide it so mouse events work. The rest of this is ptw's original change note: This is just a first pass. It doesn't reparent the input text sprite into the click tree, and it turns off the click tree when you mouse over in input element. The test case works in Safari, and Firefox. I have not tested IE. LzSprite: Correct fencepost error in __isMouseOver. LzInputTextSprite: Add documentation from Max. Fix init clauses that were causing the schema-generator to warn. Remove reparenting code, replace with hiding/showing the click tree. Now we can just turn the whole click tree on and off, since we are not reparenting, which should be much more efficient. Only re-enable click tree when we _actually_ leave the bounding box of the input element. Tests: Test case from LPP-8334. Also see lpp-5447.lzx attached to the bug and Files: M WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js M WEB-INF/lps/lfc/kernel/dhtml/LzTextSprite.js M WEB-INF/lps/lfc/kernel/dhtml/LzMouseKernel.js M WEB-INF/lps/lfc/kernel/dhtml/LzInputTextSprite.js Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20090727-maxcarlson-U.tar _______________________________________________ Laszlo-reviews mailing list [email protected] http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews
