Yes, André is correct - you need to use CamelCase when setting CSS properties in script to avoid parsing issues with properties like 'background-color'. This is the same syntax used in the LzSprite#__defaultStyles hash to write out default CSS values.
Did you intend to include the $lzc$set_rotationy work in LaszloView? If so, you probably need to add LzSprite#setRotationY() back... In any case, that work should probably go in a separate changeset. You shouldn't need to set the rotation origin every time LzSprite#setRotation() is called - instead, try setting the style when quirks are processed. See the way the hand_pointer_for_clickable is dealt with in LzSprite#__updateQuirks(). The 'threeDTransform' capability should be lower case to follow the convention used elsewhere. Also, it should be added to the other runtimes with a default value of false... Also, There's a Debug.write() statement in setRotation()... Otherwise, approved! Raju Bitter wrote: > Changed the CSS property for rotation in FF/Mozilla to 'MozTransform' > instead of '-moz-transform'. > > Change 20090803-raju-n by [email protected] on 2009-08-03 15:26:08 CEST > in /Users/rajubitter/src/svn/openlaszlo/trunk > for http://[email protected]/openlaszlo/trunk > > Summary: http://jira.openlaszlo.org/jira/browse/LPP-8362 > > New Features: Set a default rotation origin of 0% 0% or top left for > DHTML. Added code for supporting rotation in FF 3.5, using André's > suggestion to use CSS property 'MozTransform' instead of 'moz-transform'. > > Bugs Fixed: http://jira.openlaszlo.org/jira/browse/LPP-8362 > > Technical Reviewer: [email protected] > QA Reviewer: (pending) > Doc Reviewer: (pending) > > Documentation: > > Release Notes: > > Details: > This only fixes the default origin of the rotation. Haven't investigated > which behavior would be needed to make that work with xoffset and yoffset. > > Tests: > Test with the file attached to LPP-8362. > http://jira.openlaszlo.org/jira/secure/attachment/12682/LPP-8362-test-rotation.lzx > > > > Files: > M WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js > M WEB-INF/lps/lfc/views/LaszloView.lzs > > Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20090803-raju-n.tar -- Regards, Max Carlson OpenLaszlo.org _______________________________________________ Laszlo-reviews mailing list [email protected] http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews
