Hi, On Sat, Apr 9, 2011 at 11:14 PM, Luca Barbato <lu_z...@gentoo.org> wrote: > Today I planned to add to av_log() some optional features in order to > track file, line and function. > > I noticed some strange code introduced with this commit[1] > > if(avc && avc->version >= (50<<16 | 15<<8 | 2) && > avc->log_level_offset_offset && level>=AV_LOG_FATAL) > level += *(int*)(((uint8_t*)avcl) + avc->log_level_offset_offset); > av_vlog(avcl, level, fmt, vl); > > It doesn't look particularly widespread and probably could be removed or > at least documented (only libavcodec seems to use it)
I would still consider it API/ABI breakage... :-(. It looks kinda hacky indeed. Was this reviewed? Ronald _______________________________________________ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
