On 09/06/16 08:39, Anton Khirnov wrote: > Quoting Mark Thompson (2016-06-01 00:40:03) >> --- >> This field started as 0 and the bitrate-targetting set changed it to 1: it >> should be conditional on the mode because the feature is just wasting bits >> with constant-QP. >> >> libavcodec/vaapi_encode_h265.c | 5 ++++- >> 1 file changed, 4 insertions(+), 1 deletion(-) >> >> diff --git a/libavcodec/vaapi_encode_h265.c b/libavcodec/vaapi_encode_h265.c >> index 1b1cce7..3fb8bf3 100644 >> --- a/libavcodec/vaapi_encode_h265.c >> +++ b/libavcodec/vaapi_encode_h265.c >> @@ -868,7 +868,10 @@ static int >> vaapi_encode_h265_init_sequence_params(AVCodecContext *avctx) >> >> vpic->pic_fields.bits.screen_content_flag = 0; >> vpic->pic_fields.bits.enable_gpu_weighted_prediction = 0; >> - vpic->pic_fields.bits.cu_qp_delta_enabled_flag = 1; >> + >> + // Per-CU QP changes are required for non-constant RC modes. > ^^^^^^^^^^^^ > Non-constant QP you mean.
Oops, fixed. >> + vpic->pic_fields.bits.cu_qp_delta_enabled_flag = >> + ctx->va_rc_mode != VA_RC_CQP; > > Patch itself looks ok. > Thanks, - Mark _______________________________________________ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
