---
On 05/09/16 12:10, Diego Biurrun  wrote:
> Module: libav
> Branch: master
> Commit: 2610c9528f86286e4c6e174411a26ff5b4815cde
> 
> Author:    Diego Biurrun <di...@biurrun.de>
> Committer: Diego Biurrun <di...@biurrun.de>
> Date:      Tue Mar 17 13:12:41 2015 +0100
> 
> configure: Move initial VAAPI check to a more sensible place
> 
> ...
> @@ -4775,6 +4774,8 @@ if enabled libxcb; then
>      add_extralibs "$xcb_event_libs $xcb_shm_libs $xcb_xfixes_libs"
>  fi
>  
> +enabled vaapi && require vaapi va/va.h vaInitialize -lva
> +
>  enabled vaapi &&
>      check_code cc "va/va.h" "vaCreateSurfaces(0, 0, 0, 0, 0, 0, 0, 0)" ||
>      disable vaapi

Maybe this cleanup could go a bit further - I think the original form of the
vaCreateSurfaces() check came from a version in ffmpeg, where VAAPI is
autodetected rather than requiring an --enable.

Alternatively, we could let it be autodetected?  What are the criteria for
deciding to do that?  (I see that vdpau and dxva are already.)

 configure | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/configure b/configure
index ea2b131..ce435a9 100755
--- a/configure
+++ b/configure
@@ -4776,13 +4776,12 @@ if enabled libxcb; then
     add_extralibs "$xcb_event_libs $xcb_shm_libs $xcb_xfixes_libs"
 fi

-enabled vaapi && require vaapi va/va.h vaInitialize -lva
+if enabled vaapi ; then
+    require vaapi va/va.h vaInitialize -lva

-enabled vaapi &&
     check_code cc "va/va.h" "vaCreateSurfaces(0, 0, 0, 0, 0, 0, 0, 0)" ||
-    disable vaapi
+    die "ERROR: libva older than 1.2.0 is not supported"

-if enabled vaapi ; then
     enabled xlib &&
     check_lib2 "va/va.h va/va_x11.h" vaGetDisplay -lva -lva-x11 &&
     enable vaapi_x11
-- 
2.9.3

_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to