Re: [libav-devel] [PATCH 1/2] hevc: Add AVX IDCT

[Alexandra Hájková]

>>  %if HAVE_AVX2_EXTERNAL
>>  INIT_YMM avx2
>>  IDCT_DC    16,  2,  8
>> @@ -100,6 +804,12 @@ IDCT_DC_NL  8,     10
>>  IDCT_DC    16,  4, 10
>>  IDCT_DC    32, 16, 10
>>
>> +INIT_XMM avx
>> +IDCT_4x4 10
>> +IDCT_8x8 10
>> +IDCT_16x16 10
>> +IDCT_32x32 10
>
> It seems rather silly to duplicate all those functions when the only
> difference between them is the value of a constant. Perhaps it'd be
> better to change that into a parameter.
>
The problem is the same constant goes into funtion name as well.
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel