On Sat, Nov 06, 2021 at 08:30:20AM +0000, Richard W.M. Jones wrote: > > I forgot to add this file to the sources, so it is not included in the > > tarball. > > Wil fix this before pusing. > > > > I think including maintainer-check-extra-dist in the check target wil avoid > > such errors for very little cost: > > This rule only works directly after running "make dist".
Is there some way to wire this check up into the 'dist-hook' rule? Automake runs that after the distribution directory is filled, but before the archive is created. If we can get it to work, that would be a lot easier than having to remember to run a separate rule after 'make dist'. Automake also provides the 'make dist-check' rule, which would catch things like this, except that 'dist-check' ALSO tests that a VPATH build works, and we've not yet had success at fully porting our code base to be VPATH-friendly (bash completion and ocaml builds were the two that gave me the most grief last time I tried, but there may be others). -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org _______________________________________________ Libguestfs mailing list Libguestfs@redhat.com https://listman.redhat.com/mailman/listinfo/libguestfs