On Mon, Jun 16, 2008 at 03:52:31PM +0200, Chris Lalancette wrote: > This patch changes things around so that virStorageBackendRunProgRegex() does > *not* virStorageReportError() if the fork()/exec() process it spawned > returned a > != 0 exit code. Rather, it returns the exitcode in this case, and it is up to > the higher level to determine whether this is a fatal error or not. The use > case for this change is in the iSCSI stuff; older versions of iscsiadm tools > would return a failure when getting the session number, despite the command > succeeding.
Looks fine to me, +1 Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ [EMAIL PROTECTED] | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/ -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
