On Tue, Jun 02, 2015 at 14:34:08 +0200, Jiri Denemark wrote:
> Because we are polling we may detect some errors after we asked QEMU for
> migration status even though they occurred before. If this happens and
> QEMU reports migration completed successfully, we would happily report
> the migration succeeded even though we should have cancelled it because
> of the other error.
> 
> In practise it is not a big issue now but it will become a much bigger
> issue once the check for storage migration status is moved inside the
> loop in qemuMigrationWaitForCompletion.
> 
> Signed-off-by: Jiri Denemark <jdene...@redhat.com>
> ---
> 
> Notes:
>     Version 2:
>     - really do what commit message describes
>     
>     Already ACKed in version 1 :-)

/me will deny everything!

> 
>  src/qemu/qemu_migration.c | 48 
> +++++++++++++++++++++++------------------------
>  1 file changed, 23 insertions(+), 25 deletions(-)

ACK,

Peter

Attachment: signature.asc
Description: Digital signature

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Reply via email to