On Tue, Jul 07, 2015 at 05:27:39PM +0100, Zeeshan Ali (Khattak) wrote: > Hi all, > > Christophe pointed out that this and the previous patch binds API that > was added an year ago: > > commit: 03e0e79e07622496522609741734c2fdcacb5bf2 > Author: Nehal J Wani <nehaljw.k...@gmail.com> > Date: Tue Jun 24 02:31:49 2014 +0530 > > net-dhcp-leases: Implement the public APIs > > Introduce 3 new APIs, virNetworkGetDHCPLeases, > virNetworkGetDHCPLeasesForMAC > and virNetworkDHCPLeaseFree. > --------------- > > While I think 1 year old is pretty old enough to justify bumping the > dep to that version, Christophe thinks its still too soon. I'd hate to > go through the trouble of adding ugly #ifdef around these new API but > if others (I guess mainly Dan?) agree with Christophe, I can do that.
1 year being old/not old is not a very useful/convincing argument. What is more interesting is what (supported) distros are shipping (f21, el7, oldest ubuntu LTS shipping libvirt-glib, debian, ...). I'd tend to favour #ifdefs though unless this gets very invasive/ugly ;) Christophe
pgpcTxHwsjf1B.pgp
Description: PGP signature
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
