>> + */
>> +int
>> +virLogDefineFilters(virLogFilterPtr *filters, size_t nfilters)
>> +{
>> + if (virLogInitialize() < 0)
>> + return -1;
>> +
>> + virLogLock();
>> + virLogResetOutputs();
>
> Copy/Paste error - s/b virLogResetFilters(); ?
>
>> + virLogFilters = filters;
>> + virLogNbOutputs = nfilters;
>
> Similar copy/paste error s/b virLogNbFilters
>
>> + virLogFiltersSerial++;
>
> And since virLogResetFilters updates this, it's not required to do it
> twice right?You're absolutely right, I failed to see it but since we're already holding the lock on the mutex, despite the fact that serial testing is done concurrently, no source update can take place unless the lock is released, thanks. Erik
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
