On Thu, 2019-01-10 at 16:20 +0300, Roman Bolshakov wrote: > Perhaps we should install grep, gnu-sed and cppi from homebrew in > .travis.yml to get it working. I have all of them installed on my laptop > and syntax-check passes without the errors for me. > > grep provides GNU grep and all the "empty (sub)expression" statements > should be gone if it's installed. > > sed on macOS doesn't support "-r flag" but supports "-E". Novertheless, > prohibit_diagnostic_without_format relies on regular expressions that > are not supported in macOS: > > prohibit_diagnostic_without_format > sed: 1: "/\<(|VIR_ERROR|lxcError ...": RE error: empty (sub)expression > > We need gnu-sed for the rule.
Sure we can install cppi, but I think we should try to make our tests portable rather than throwing in the towel and installing the GNU tools, especially since making sure we pick those up instead of the BSD equivalents, which at least on FreeBSD come first in $PATH, would require adding even more autotools trickery... -- Andrea Bolognani / Red Hat / Virtualization -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
