On Thu, Mar 21, 2019 at 18:28:55 -0400, Laine Stump wrote: > qemuDomainDetachDeviceLive() is called from two places in > qemu_driver.c. Move the call to qemuDomainUpdateDeviceList() from the > end of that function, which is now in qemu_hotplug.c, to the two > places that call qemuDomainDetachDeviceLive(). > > Removing that one call from qemuDomainDetachDeviceList() will permit > us to call it from the test driver, replacing the separate calls to > qemuDomainDetachDeviceDiskLive(), qemuDomainDetachChrDevice(), > qemuDomainDetachShmemDevice() and qemuDomainDetachWatchdog(). We want > to do this so that part of the common functionality of those three > functions (and the rest of the device-specific Detach functions) can > be pulled up into qemuDomainDetachDeviceLive() without breaking the > test. (This is done in the next patch).
I think actually that calling qemuDomainUpdateDeviceList does not make much sense in qemuDomainDetachDeviceLive. At that point the device still may not be removed. Calling it from the DEVICE_DELETED handler should be sufficient.
signature.asc
Description: PGP signature
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
