On 4/13/19 5:17 PM, Bjoern Walk wrote:
> <snip/>
> 
> This breaks build on S390:
> 
>       ../../src/util/virhostcpu.c: In function 'virHostCPUGetMSRFromKVM':
>       ../../src/util/virhostcpu.c:1267:25: error: field 'header' has 
> incomplete type
>                        struct kvm_msrs header;
>                                                        ^~~~~~
>       ../../src/util/virhostcpu.c:1268:30: error: field 'entry' has 
> incomplete type
>                        struct kvm_msr_entry entry;
>                                                                 ^~~~~
>       ../../src/util/virhostcpu.c:1270:21: error: field name not in record or 
> union initializer
>                        .header = { .nmsrs = 1 },
>                                                ^
>       ../../src/util/virhostcpu.c:1270:21: note: (near initialization for 
> 'msr.header')
>       ../../src/util/virhostcpu.c:1271:20: error: field name not in record or 
> union initializer
>                        .entry = { .index = index },
>                                               ^
>       ../../src/util/virhostcpu.c:1271:20: note: (near initialization for 
> 'msr.entry')
>       In file included from /usr/include/asm/ioctl.h:1,
>                                        from /usr/include/linux/ioctl.h:5,
>                                        from 
> /usr/include/asm-generic/ioctls.h:5,
>                                        from /usr/include/asm/ioctls.h:7,
>                                        from /usr/include/bits/ioctls.h:23,
>                                        from /usr/include/sys/ioctl.h:26,
>                                        from ../gnulib/lib/sys/ioctl.h:27,
>                                        from ../../src/util/virhostcpu.c:27:
>       ../../src/util/virhostcpu.c:1279:19: error: invalid application of 
> 'sizeof' to incomplete type 'struct kvm_msrs'
>                if (ioctl(fd, KVM_GET_MSRS, &msr) < 0) {

Yep, it breaks the build on my arm box too. MSRs are specific to x86. I
guess we need to put some more #ifdef-s in. Let me see if I can cook a
patch.

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Reply via email to