On Thu, 2019-08-08 at 16:37 +0100, Daniel P. Berrangé wrote: > On Thu, Aug 08, 2019 at 05:33:40PM +0200, Andrea Bolognani wrote: > > On Thu, 2019-08-08 at 16:10 +0100, Daniel P. Berrangé wrote: > > > +++ b/src/remote/remote_daemon_dispatch.c > > > @@ -2077,6 +2105,9 @@ remoteDispatchConnectOpen(virNetServerPtr server > > > ATTRIBUTE_UNUSED, > > > unsigned int flags; > > > struct daemonClientPrivate *priv = > > > virNetServerClientGetPrivateData(client); > > > int rv = -1; > > > +#ifdef MODULE_NAME > > > + const char *type = NULL; > > > +#endif /* !MODULE_NAME */ > > > > Nit: the comment should read > > > > /* ! MODULE_NAME */ > > I don't see any reason to change that here - with & without the space > are both widely used across libvirt
All the other comments you're introducing in the series have that format, but sure, I'm okay with not changing it. Just make sure you change those in 20/42 because there the logic is actually wrong. -- Andrea Bolognani / Red Hat / Virtualization -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
