On Tue, Jan 28, 2020 at 01:10:57PM +0000, Daniel P. Berrangé wrote: > A large part of the virCommand code is still built on > WIN32, despite the fact that the core fork() & execve() > functions are not available. So despite succesfully > building most of the code, at runtime the APIs are > none the less unusuable. With the elimination of GNULIB > many of the APIs being used in this code no longer have > portability wrappers/shims for Windows. > > Rather than try to add portability wrappers, or do tests > for each individual function, it is clearer to conditionalize > nearly all of the code using #ifdef WIN32. > > Signed-off-by: Daniel P. Berrangé <berra...@redhat.com> > --- > src/util/vircommand.c | 165 ++++++++++++++++++++++++++---------------- > 1 file changed, 103 insertions(+), 62 deletions(-)
Reviewed-by: Pavel Hrdina <phrd...@redhat.com>
signature.asc
Description: PGP signature
