On Tue, 2020-03-24 at 14:33 -0300, Daniel Henrique Barboza wrote: > The 'pvspinlock' feature is x86 only. The "<pvspinlock/>" declaration > will always have a value 'on' or 'off', and both will break QEMU when > launching non-x86 guests. This is the error message for > "<pvspinlock state='on'/>" when running a ppc64 guest: > > qemu-kvm: Expected key=value format, found +kvm_pv_unhalt > > A similar error message is thrown for "<pvspinlock state='off'/>". > > This patch prevents non-x86 guests from launching with any > pvspinlock setting with a more informative error message: > > error: unsupported configuration: The 'pvspinlock' feature is not > supported for architecture 'ppc64' or machine type 'pseries' > > Suggested-by: Andrea Bolognani <abolo...@redhat.com> > Signed-off-by: Daniel Henrique Barboza <danielhb...@gmail.com> > --- > src/qemu/qemu_domain.c | 14 +++++++++++++- > 1 file changed, 13 insertions(+), 1 deletion(-)
Reviewed-by: Andrea Bolognani <abolo...@redhat.com> -- Andrea Bolognani / Red Hat / Virtualization
