On 02/15/2010 06:33 AM, Matthias Bolte wrote: > 2010/2/12 Cole Robinson <crobi...@redhat.com>: >> SetMem and SetMaxMem are hotplug only APIs, any persistent config >> changes are supposed to go via XML definition. The original implementation >> of these calls were incorrect and had the nasty side effect of making >> a psuedo persistent change that would be lost after libvirtd restart >> (I didn't know any better). >> >> Fix these APIs to rightly reject non running domains. >> --- > > Could you document this somewhere that virDomainSetMaxMemory may be > called for active domains only, like in the documentation of > virDomainSetMaxMemory in libvirt.c? > > Several details of the libvirt API are only documentation deep down in > the mailing list, or the developers heads. > > Now you've fixed the code to do what is supposed to do, but it's still > not documented well. > > The same goes for the other commit where you made it callable for an > active domain only. >
Good point. I'll write up a docs patch. Thanks, Cole -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
