On 02/09/2011 11:49 AM, Laine Stump wrote: > On 02/01/2011 05:36 PM, Eric Blake wrote: >> * Makefile.am (EXTRA_DIST): Distribute cfg.mk. >> --- >> >> I noticed that the 0.8.7 tarball lacks cfg.mk, so running 'make >> syntax-check' on that tarball is bound to have problems (without that >> file, you don't exempt tests in gnulib's maint.mk that libvirt is not >> interested in, and you miss out on lots of other tests that are >> libvirt-specific). >> >> Tested with 'make distcheck', then inspecting the resulting tarball. >> I almost pushed this under a trivial rule, but restrained myself to >> wait for a proper review. :) > > I tried this out by removing cfg.mk and trying to run make syntax-check. > It definitely doesn't like that, so it makes sense to include the file. > > ACK.
Thanks; pushed. -- Eric Blake ebl...@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
