On 01/09/2012 07:29 AM, Osier Yang wrote: > --- Mention the API name in the commit message, so that grepping 'git log' makes it easier to find when the API was added.
> include/libvirt/libvirt.h.in | 3 +++ > src/driver.h | 5 +++++ > src/libvirt_public.syms | 5 +++++ > 3 files changed, 13 insertions(+), 0 deletions(-) I would combine this patch with 2/6 - that is, the declaration and the documentation should belong in the same patch (otherwise, I don't know if the declaration makes sense). > > diff --git a/include/libvirt/libvirt.h.in b/include/libvirt/libvirt.h.in > index ad6fcce..5f2c46b 100644 > --- a/include/libvirt/libvirt.h.in > +++ b/include/libvirt/libvirt.h.in > @@ -3600,6 +3600,9 @@ int virConnectSetKeepAlive(virConnectPtr conn, > int interval, > unsigned int count); > > +char *virDomainNormalizeDeviceXML(virDomainPtr dom, This should _not_ be tied to a specific domain, but should be a general-purpose virConnectPtr operation. After all, it has no impact on the state of current libvirt objects in use; it is merely a way to expose the mapping of XML into conf/*_conf.c C structures and back into XML format. See also my comments on 0/6 about making it more generic, to cover more than just <domain>. -- Eric Blake ebl...@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
