On 09/05/2012 02:28 PM, Kyle Mestery (kmestery) wrote: > On Sep 5, 2012, at 1:24 PM, Laine Stump wrote: >> This fixes https://bugzilla.redhat.com/show_bug.cgi?id=852984 >> >> If a network or interface is configured to use Open vSwitch, but >> ovs-vswitchd (the Open vSwitch database service) isn't running, the >> ovs-vsctl add-port/del-port commands will hang indefinitely rather >> than returning an error. There is a --nowait option, but that appears >> to have no effect on add-port and del-port commands, so instead we add >> a --timeout=5 to the commands - they will retry for up to 5 seconds, >> then fail if there is no response. > > This looks good. I agree with your comments here around the 5 second > timeout not being ideal, but being workable.
Thanks. I pushed it, but feel free to revisit if you come up with a better solution. (I greatly dislike any hardcoded timeout and only use them as a last resort). -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
