On 04/04/2014 08:36 AM, John Ferlan wrote: > Commit id '18642d10' refactored the call to virCommandRunRegex() > inside a new function virStorageBackendFileSystemNetFindNFSPoolSources(), > but the cut-n-paste didn't remove the "&state". Now that state is passed > by reference, it results in a libvirtd core with a messages entry: > > "...internal error: unknown storage pool type Unknow" > > Signed-off-by: John Ferlan <jfer...@redhat.com> > --- > src/storage/storage_backend_fs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/storage/storage_backend_fs.c > b/src/storage/storage_backend_fs.c > index 1d85871..4e4a7ae 100644 > --- a/src/storage/storage_backend_fs.c > +++ b/src/storage/storage_backend_fs.c > @@ -266,7 +266,7 @@ > virStorageBackendFileSystemNetFindNFSPoolSources(virNetfsDiscoverState *state) > > if (virCommandRunRegex(cmd, 1, regexes, vars, > virStorageBackendFileSystemNetFindPoolSourcesFunc, > - &state, NULL) < 0) > + state, NULL) < 0)
Eww that the compiler couldn't flag this - but that really is the void* opaque argument where the burden is on us to pass the correct type. ACK. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
