Hi David,

On Thu, Nov 8, 2012 at 9:27 AM,  <d...@gnu.org> wrote:
> [snip detailed explanation]

thanks for explaining and sorry for not looking this up myself - i'm
short on time and thus i do all reviews in a hurry...

> The commit message might be misleading, however, since it sounds like it
> is touting a fundamental new feature.  What this is is more like putting
> another piece in place for the general idea of "strings/markups can be
> submitted like any Scheme expression would".  It is more like plugging
> an oversight rather than adding something new.

Ok, i see your point.  However, since original author of that code did
it wrong, i still believe that it'd be good to make information about
it somewhat more visible, so that other people could learn from that
mistake.  You may just dump this info into GC miscellaneous.

Anyway, feel free to do whatever you decide, and LGTM :)
Janek

_______________________________________________
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Reply via email to