On Mon, Mar 5, 2018 at 5:19 PM, Guenter Roeck <[email protected]> wrote: > On Mon, Mar 05, 2018 at 03:57:37PM -0600, Rob Herring wrote: >> On Mon, Feb 26, 2018 at 03:19:05PM -0800, Guenter Roeck wrote: >> > Since commit 4670d610d5923 ("PCI: Move OF-related PCI functions into >> > PCI core"), sparc:allmodconfig fails to build with the following error. >> > >> > pcie-cadence-host.c:(.text+0x4c4): >> > undefined reference to `of_irq_parse_and_map_pci' >> > pcie-cadence-host.c:(.text+0x4c8): >> > undefined reference to `of_irq_parse_and_map_pci' >> > >> > of_irq_parse_and_map_pci is now only available if OF_IRQ is enabled. >> > Make its declaration and its dummy function dependent on OF_IRQ >> > to solve the problem. >> > >> > Fixes: 4670d610d5923 ("PCI: Move OF-related PCI functions into PCI core") >> > Cc: Rob Herring <[email protected]> >> > Signed-off-by: Guenter Roeck <[email protected]> >> > --- >> > include/linux/of_pci.h | 17 ++++++++++------- >> > 1 file changed, 10 insertions(+), 7 deletions(-) >> >> Bjorn should take this. Can you resend to linux-pci so it is in his >> queue. >> > MAINTAINERS lists you as maintainer and [email protected] as > mailing list. But, sure, no problem.
The commit it fixes went in thru his tree was my reasoning. I'll look at fixing MAINTAINERS. Ideally, the header would move to drivers/pci/, but since all the PPC PCI host code is still in arch/powerpc, it cannot. Rob
