Commit-ID: f93877214a83e88373b20801c2d671923d03d07d Gitweb: https://git.kernel.org/tip/f93877214a83e88373b20801c2d671923d03d07d Author: Thomas Gleixner <t...@linutronix.de> AuthorDate: Thu, 25 Apr 2019 11:44:59 +0200 Committer: Thomas Gleixner <t...@linutronix.de> CommitDate: Mon, 29 Apr 2019 12:37:48 +0200
latency_top: Simplify stack trace handling Replace the indirection through struct stack_trace with an invocation of the storage array based interface. Signed-off-by: Thomas Gleixner <t...@linutronix.de> Reviewed-by: Josh Poimboeuf <jpoim...@redhat.com> Cc: Andy Lutomirski <l...@kernel.org> Cc: Steven Rostedt <rost...@goodmis.org> Cc: Alexander Potapenko <gli...@google.com> Cc: Alexey Dobriyan <adobri...@gmail.com> Cc: Andrew Morton <a...@linux-foundation.org> Cc: Christoph Lameter <c...@linux.com> Cc: Pekka Enberg <penb...@kernel.org> Cc: linux...@kvack.org Cc: David Rientjes <rient...@google.com> Cc: Catalin Marinas <catalin.mari...@arm.com> Cc: Dmitry Vyukov <dvyu...@google.com> Cc: Andrey Ryabinin <aryabi...@virtuozzo.com> Cc: kasan-...@googlegroups.com Cc: Mike Rapoport <r...@linux.vnet.ibm.com> Cc: Akinobu Mita <akinobu.m...@gmail.com> Cc: Christoph Hellwig <h...@lst.de> Cc: io...@lists.linux-foundation.org Cc: Robin Murphy <robin.mur...@arm.com> Cc: Marek Szyprowski <m.szyprow...@samsung.com> Cc: Johannes Thumshirn <jthumsh...@suse.de> Cc: David Sterba <dste...@suse.com> Cc: Chris Mason <c...@fb.com> Cc: Josef Bacik <jo...@toxicpanda.com> Cc: linux-bt...@vger.kernel.org Cc: dm-de...@redhat.com Cc: Mike Snitzer <snit...@redhat.com> Cc: Alasdair Kergon <a...@redhat.com> Cc: Daniel Vetter <dan...@ffwll.ch> Cc: intel-...@lists.freedesktop.org Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com> Cc: Maarten Lankhorst <maarten.lankho...@linux.intel.com> Cc: dri-de...@lists.freedesktop.org Cc: David Airlie <airl...@linux.ie> Cc: Jani Nikula <jani.nik...@linux.intel.com> Cc: Rodrigo Vivi <rodrigo.v...@intel.com> Cc: Tom Zanussi <tom.zanu...@linux.intel.com> Cc: Miroslav Benes <mbe...@suse.cz> Cc: linux-a...@vger.kernel.org Link: https://lkml.kernel.org/r/20190425094801.683039...@linutronix.de --- kernel/latencytop.c | 17 ++--------------- 1 file changed, 2 insertions(+), 15 deletions(-) diff --git a/kernel/latencytop.c b/kernel/latencytop.c index f5a90ab3c6b9..99a5b5f46dc5 100644 --- a/kernel/latencytop.c +++ b/kernel/latencytop.c @@ -141,20 +141,6 @@ account_global_scheduler_latency(struct task_struct *tsk, memcpy(&latency_record[i], lat, sizeof(struct latency_record)); } -/* - * Iterator to store a backtrace into a latency record entry - */ -static inline void store_stacktrace(struct task_struct *tsk, - struct latency_record *lat) -{ - struct stack_trace trace; - - memset(&trace, 0, sizeof(trace)); - trace.max_entries = LT_BACKTRACEDEPTH; - trace.entries = &lat->backtrace[0]; - save_stack_trace_tsk(tsk, &trace); -} - /** * __account_scheduler_latency - record an occurred latency * @tsk - the task struct of the task hitting the latency @@ -191,7 +177,8 @@ __account_scheduler_latency(struct task_struct *tsk, int usecs, int inter) lat.count = 1; lat.time = usecs; lat.max = usecs; - store_stacktrace(tsk, &lat); + + stack_trace_save_tsk(tsk, lat.backtrace, LT_BACKTRACEDEPTH, 0); raw_spin_lock_irqsave(&latency_lock, flags);
