On Mon, Sep 20, 2010 at 08:09:26AM -0400, zhangfei gao wrote: > On Mon, Sep 20, 2010 at 5:50 AM, Wolfram Sang <w.s...@pengutronix.de> wrote: > > On Mon, Sep 20, 2010 at 05:46:02PM +0800, zhangfei gao wrote: > > > >> diff --git a/drivers/mmc/host/sdhci-pxa.c b/drivers/mmc/host/sdhci-pxa.c > >> new file mode 100644 > >> index 0000000..3e091c1 > >> --- /dev/null > >> +++ b/drivers/mmc/host/sdhci-pxa.c > >> @@ -0,0 +1,253 @@ > >> +/* linux/drivers/mmc/host/sdhci-pxa.c > >> + * > >> + * Copyright 2010 Marvell > >> + * Zhangfei Gao <zhangfei....@marvell.com> > >> + * > >> + * This program is free software; you can redistribute it and/or modify > >> + * it under the terms of the GNU General Public License version 2 as > >> + * published by the Free Software Foundation. > >> + */ > >> + > >> +/* Supports: > >> + * SDHCI support for MMP2/PXA910/PXA168 > >> + * > >> + * Based on sdhci-platfm.c > >> + */ > > > > Why is it only "based on" and not directly using it? > > Thanks for your suggestion. > This is the first stage, already implement sd card function, we will > have some patches later to enhance the driver. > We have to access many private registers to enable specific control. > Besides some sdio device need some specific control, like marvell 8787 > host sleep, it is much reasonable to implement inside the driver.
Hmm, which hooks are missing for you to implement this as an extension of the pltfm-driver? Maybe it makes sense to simply add this hook? -- Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signature
