On Wed, Apr 27, 2011 at 01:49:45PM -0700, Philip Rakity wrote:
> The patches were submitted a while ago.

It would be a good idea to reference them so that people know where to
find then and what the status of them is.  It's also a good idea to
Cc interested parties on related patches.

A couple of points in one of those patches though:

> +     if(gpio_request(reset, "sd8xxx reset")) {

space between if and (.

> +             printk(KERN_INFO "gpio %d request failed\n", reset);
> +             return;
> +     }
> +
> +     if(gpio_request(poweron, "sd8xxx PDn")) {
> +             gpio_free(reset);
> +             printk(KERN_INFO "gpio %d request failed\n", poweron);
> +             return;
> +     }
> +
> +     gpio_direction_output(poweron, 1);
> +     msleep (1);

No space between msleep and (.
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to