Hello Jaehoon, On 11/06/2012 10:40 AM, Jaehoon Chung wrote: > Hi Konstantin, > ... >> >> @@ -1406,6 +1401,7 @@ static int mmc_blk_issue_rq(struct mmc_queue *mq, >> struct request *req) >> ret = 0; >> goto out; >> } >> + mq->flags &= ~MMC_QUEUE_NEW_REQUEST; > I didn't understand why clearing the MMC_QUEUE_NEW_REQUEST. > Sorry, Could you explain to me? I didn't read the previous patch. > If mentioned about this before, I will read them. > > Best Regards, > Jaehoon Chung
This flag used as indication that mmc_blk_issue_rw_rq() returned because of new request notification, so the flow continues rollback to fetch new request from mmc_queue_thread() (queue.c). Before calling the mmc_blk_issue_rw_rq() need to clear the flag to be able to trigger it again and to differ the case with new packet notification from legacy flow (when returning from mmc_blk_issue_rw_rq() because request is done/finished. Thanks, -- Konstantin Dorfman, QUALCOMM ISRAEL, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
