Воскресенье, 23 февраля 2014, 23:10 +01:00 от Guennadi Liakhovetski
<g.liakhovet...@gmx.de>:
> Hi Alexander,
>
> Sorry, this isn't going to be a complete review, just a couple of
> comments.
>
> On Sun, 23 Feb 2014, Alexander Shiyan wrote:
>
> > This is a RFC patch only, please do not apply it.
> >
> > This introduce a conversion slot-gpio to gpiod-* API.
> > Usage of gpiod-* API allows us to remove all pieces of storage
> > GPIOs in the driver's platform_data in the future.
> > Patch saves calls to existing functions that allows us to convert
> > all drivers to use new interface, one by one.
> > Ready for comments and suggestions.
> > ---
...
> > struct mmc_gpio {
> > - int ro_gpio;
> > - int cd_gpio;
> > - char *ro_label;
> > - char cd_label[0];
> > + struct gpio_desc *ro_gpio;
> > + struct gpio_desc *cd_gpio;
> > + char *cd_label;
>
> First question: has this patch been run-time tested?
No, it is only for overview the general concept.
---
