On 11:19 Wed 21 Apr , Al Chu wrote: > Hey Sasha, > > A slight tweak to the patch. Support diffing lids and node descriptions > on remote ports (previously it diffed only "local" lids and node > descriptions). Also add appropriate manpage notes. > > Al > > On Tue, 2010-04-20 at 15:30 -0700, Al Chu wrote: > > Hey Sasha, > > > > This patch supports diffing node descriptions on remote ports > > (previously diffing of just the "local" node description was supported). > > > > Al > > > > email message attachment > > > -------- Forwarded Message -------- > > > From: Albert Chu <ch...@llnl.gov> > > > Subject: [PATCH] support diffing nodedesc on remoteports in > > > ibnetdiscover > > > Date: Tue, 20 Apr 2010 15:09:59 -0700 > > > > > > Signed-off-by: Albert Chu <ch...@llnl.gov> > > > --- > > > infiniband-diags/src/ibnetdiscover.c | 11 +++++++++++ > > > 1 files changed, 11 insertions(+), 0 deletions(-) > > > > > > diff --git a/infiniband-diags/src/ibnetdiscover.c > > > b/infiniband-diags/src/ibnetdiscover.c > > > index 57f9625..eeb1b9f 100644 > > > --- a/infiniband-diags/src/ibnetdiscover.c > > > +++ b/infiniband-diags/src/ibnetdiscover.c > > > @@ -720,6 +720,17 @@ static void diff_ports(ibnd_node_t * fabric1_node, > > > ibnd_node_t * fabric2_node, > > > fabric2_out++; > > > } > > > > > > + if (data->diff_flags & DIFF_FLAG_PORT_CONNECTION > > > + && data->diff_flags & DIFF_FLAG_NODE_DESCRIPTION > > > + && fabric1_port && fabric2_port > > > + && fabric1_port->remoteport && fabric2_port->remoteport > > > + && memcmp(fabric1_port->remoteport->node->nodedesc, > > > + fabric2_port->remoteport->node->nodedesc, > > > + IB_SMP_DATA_SIZE)) { > > > + fabric1_out++; > > > + fabric2_out++; > > > + } > > > + > > > if (fabric1_out) { > > > diff_iter_out_header(fabric1_node, data, > > > out_header_flag); > -- > Albert Chu > ch...@llnl.gov > Computer Scientist > High Performance Systems Division > Lawrence Livermore National Laboratory
> Date: Tue, 20 Apr 2010 15:09:59 -0700 > From: Albert Chu <ch...@llnl.gov> > Subject: [PATCH] support diffing lids and nodedesc on remoteports in > ibnetdiscover > Message-Id: <1271873984.17987.245.ca...@auk31.llnl.gov> > Mime-Version: 1.0 > Content-Transfer-Encoding: 7bit > > > Signed-off-by: Albert Chu <ch...@llnl.gov> Both applied. Thanks. Sasha -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html