On Mon, 2010-12-27 at 16:37 +0100, Bart Van Assche wrote:
> On Thu, Dec 23, 2010 at 10:31 PM, David Dillow <dillo...@ornl.gov> wrote:
> > [ ... ]
> > @@ -876,7 +876,7 @@ static int __srp_post_send(struct srp_target_port
> > *target,
> > ret = ib_post_send(target->qp, &wr, &bad_wr);
> >
> > if (!ret) {
> > - ++target->tx_head;
> > + list_del_init(&iu->list);
>
> Why list_del_init() here instead of list_del() ?
I misread the list debugging code, and got the mistaken idea that it
also checked the list_head being added to the list.
> > + INIT_LIST_HEAD(&target->tx_ring[i]->list);
> > + list_add(&target->tx_ring[i]->list, &target->free_tx);
>
> Why is INIT_LIST_HEAD() invoked above ? list_add() overwrites the prev
> and next pointers that have been cleared by INIT_LIST_HEAD().
Yeah, same deal. Will fix them both.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
