On Thu, Jan 13, 2011 at 12:06:19PM -0500, J.L. Burr wrote: > However, I had a new concern about both the mthca and mlx4 changes so far: > Are we sure using the phys_addr_t type is the correct thing to do?
I'd say this is right. It looks to me like the choice has been made to just drop BAR's that have 64 bit addresses if the system is 32 bit. Although, while looking into this I wonder J.L., how does your PCI device even work? Look at, eg pci_read_bridge_mmio_ref, it seems to me it will bail if a bridge is seen with a 64 bit setting but the system isn't 64 bit? IMHO, this is a bug, it should be testing for sizeof(resource_size_t) Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
