On 05/16/2011 10:53 AM, Roland Dreier wrote:
On Mon, May 16, 2011 at 8:18 AM, Steve Wise<sw...@opengridcomputing.com>  wrote:
Roland, I need to recall this patch.  It appears to have some problem.
Good thing I didn't apply it yet.

I did think it should be possible to declare wait objects on the stack... the
origin of completions was to handle exactly that issue; the older semaphore
structure was vulnerable to the wakeup after free, but completions handle
that.  But I didn't look at the cxgb4 code at all...

I'm pretty sure the race exists as described in my commit comment. And I don't see how the wait object code could avoid this issue. Unless I'm just all wrong. :)


--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to