> I was expecting there is an ib_device->uverbs_cmd_mask > flag which siw does not set... Unfortunately, it is not > completely clear to me when a command mask bit is available > and when the OFA core strictly expects a function pointer. > Maybe there is some redundancy/inconsistency?
The uverbs_cmd_mask controls which commands userspace can send down. A kernel consumer does not go through the code that checks this mask. It does seem we are missing an IB_MANDATORY_FUNC entry for modify_port in ib_device_check_mandatory; or on the flip side we are missing a check of modify_port and a -ENOSYS return... I guess modify_port does not really make sense for iWARP so probably the second option is better. - R. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
