On 3/9/2013 4:04 PM, Marciniszyn, Mike wrote:
This patch will conflict with
http://marc.info/?l=linux-rdma&m=136190765729001&w=2.
Mike
-----Original Message-----
From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma-
ow...@vger.kernel.org] On Behalf Of Or Gerlitz
Sent: Thursday, March 07, 2013 12:11 PM
To: rol...@kernel.org
Cc: linux-rdma@vger.kernel.org; Shlomo Pongratz
Subject: [PATCH V3 for-next 3/5] IB/ipoib: Move to multi-queue device
Hi Mike,
You didn't mentioned but you have changed the order of the call to
"netif_stop_queue" and the call to "ib_req_notify_cq", by placing the
"netif_stop_queue" before the call to "ib_req_notify_cq".
IMO you've solved a theoretical bug in which the the handler might be
called and finish before the call to the call to "netif_stop_queue",
which would result in a stopped queue.
I guess the same reordering should be done in "ipoib_ib.c::ipoib_send".
Thanks.
S.P.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
