Hi Olof, On Sun, Jul 22, 2018 at 12:27 AM Olof Johansson <o...@lixom.net> wrote: > On Fri, Jul 20, 2018 at 02:03:54PM +0200, Simon Horman wrote: > > Please consider these Renesas ARM based SoC defconfig updates for v4.19.
> > * Set CONFIG_LOCALVERSION to shmobile_defconfig > > > > This follows what appears to be common practice in defconfigs > > and allows easier management of the kernel flavour at run-time. > > I replied to the multi-versions of defconfig for this patch -- it's not a good > way to solve the problem of detecting config at runtime. Please drop this > patch. See: > > https://lore.kernel.org/lkml/CAOesGMgkU6yBRpAsED2fPyuAo9Tc=yprndgdkmbvrc+0783...@mail.gmail.com/ One more comment to the rescue: it does complicate regression testing, as the test software running on the DUT has no easy way to distinguish between e.g. shmobile_defconfig and multi_v7_defconfig (and whatever other board-specific configs I use for testing). Yes, I can have these as local patches in my tree (of course I already have ;-), but when bisecting, I have to remember to (un)apply them in every step. Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
