> It isn't really that hard to add a function to the API to do that.
> In fact the attached patch does just that.
> Last time I proposed such an interface it was rejected.

I'm not sure I see what the deal is.  The FILL_*_URB() macros
initialize URBs, including doing the spin lock init.  So there is
already an API functionality to do this; allocation and init are
already separated.

It's been pointed out that the URB fields aren't quite documented
well enough, but any driver using those FILL_*_URB() macros
to (re)init URBs is clearly doing a safe thing, and any driver that
is NOT doing that is taking risks of some kind.

A good API cleanup would be to turn these into inline functions
and provide kernel doc, preferably with a name change (use
lowercase names like usb_fill_XXX_urb etc); also probably
define another variant for ISO urbs.

- Dave



_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
http://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to