Greg:

Even when the URB_SHORT_NOT_OK flag is set, a short transfer shouldn't 
generate a debugging log message.  Especially not one with the confusing 
claim that the transfer "failed with status 0".  This patch (as627) fixes 
that behavior in uhci-hcd.

Alan Stern



Signed-off-by: Alan Stern <[EMAIL PROTECTED]>

---

Note that this patch must be applied after the as623-626 series.

Index: usb-2.6/drivers/usb/host/uhci-q.c
===================================================================
--- usb-2.6.orig/drivers/usb/host/uhci-q.c
+++ usb-2.6/drivers/usb/host/uhci-q.c
@@ -922,7 +922,6 @@ static int uhci_result_common(struct uhc
 td_error:
        ret = uhci_map_status(status, uhci_packetout(td_token(td)));
 
-err:
        if ((debug == 1 && ret != -EPIPE) || debug > 1) {
                /* Some debugging code */
                dev_dbg(uhci_dev(uhci), "%s: failed with status %x\n",
@@ -934,6 +933,7 @@ err:
                        lprintk(errbuf);
                }
        }
+err:
 
        /* Note that the queue has stopped and save the next toggle value */
        urbp->qh->element = UHCI_PTR_TERM;



-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to