On 2/16/14, 18:27, "Ong, Boon Leong" <boon.leong....@intel.com> wrote:
>> -----Original Message----- >> From: linux-yocto-boun...@yoctoproject.org [mailto:linux-yocto- >> boun...@yoctoproject.org] On Behalf Of Darren Hart >> Sent: Saturday, February 15, 2014 8:31 AM >> To: Linux Yocto >> Cc: Darren Hart >> Subject: [linux-yocto] [PATCH 1/2] baytrail: Add feature/soc/baytrail >> >> Add support for the various devices on the BayTrail SoCs, including PWM, >> SPI, I2C, ASOC, UARTs, DMA, LPSS, etc. >> >> Signed-off-by: Darren Hart <dvh...@linux.intel.com> >> --- >> .../features/soc/baytrail/baytrail.cfg | 61 >>++++++++++++++++++++ >> .../features/soc/baytrail/baytrail.scc | 13 +++++ >> 2 files changed, 74 insertions(+) >> create mode 100644 meta/cfg/kernel- >> cache/features/soc/baytrail/baytrail.cfg >> create mode 100644 meta/cfg/kernel- >> cache/features/soc/baytrail/baytrail.scc >> >> diff --git a/meta/cfg/kernel-cache/features/soc/baytrail/baytrail.cfg >> b/meta/cfg/kernel-cache/features/soc/baytrail/baytrail.cfg >> new file mode 100644 >> index 0000000..cf46d2b8 >> --- /dev/null >> +++ b/meta/cfg/kernel-cache/features/soc/baytrail/baytrail.cfg >> @@ -0,0 +1,61 @@ >> +CONFIG_PCI=y >> + >> +CONFIG_INPUT=y >> +CONFIG_INPUT_EVDEV=y >> + >> +CONFIG_SOUND=y >> +CONFIG_SND=y >> +CONFIG_SND_HDA_INTEL=y > >> +CONFIG_SND_SOC=m >> +CONFIG_SND_DESIGNWARE_I2S=m >> +CONFIG_SND_SOC_I2C_AND_SPI=m >> +CONFIG_SND_SIMPLE_CARD=m >Are the above configs meant to enable a specific skus of BYT with >designware I2S? >For BYT-I, the ASoC is not upstream yet. Thank you for the review - I don't have the same insight into the silicon as your team, I will update the fragment per your comments. Much appreciated. > >> + >> +CONFIG_BACKLIGHT_LCD_SUPPORT=y >> +CONFIG_BACKLIGHT_CLASS_DEVICE=y >> + >> +# SATA Support >> +CONFIG_ATA=y >> +CONFIG_SATA_AHCI=y >> +CONFIG_CHR_DEV_SG=y >> + >> +CONFIG_X86_INTEL_LPSS=y >> + >> +CONFIG_PINMUX=y >> +CONFIG_PINCONF=y >> +CONFIG_PINCTRL_BAYTRAIL=y >> + >> +CONFIG_SERIAL_8250_DW=y >> + >> +# MMC / SDHCI Support >> +CONFIG_MMC=y >> +CONFIG_MMC_SDHCI=y >> +CONFIG_MMC_SDHCI_PCI=y >> +CONFIG_MMC_SDHCI_ACPI=y >> + >> +CONFIG_I2C_DESIGNWARE_CORE=m >> +CONFIG_I2C_DESIGNWARE_PLATFORM=m > >> +CONFIG_I2C_DESIGNWARE_PCI=m >drivers/i2c/busses/i2c-designware-pcidrv.c does not contain BYT support >yet, >so is this intentional to make it "m" now? Mostly erring on the side of caution, better to enable more than necessary than to inadvertently disable something we need. I will drop this from the fragment. > >> + >> +# SMBus Support >> +CONFIG_I2C_I801=m >> + >> +CONFIG_SPI_PXA2XX=m >> +CONFIG_SPI_PXA2XX_PCI=m >drivers/spi/spi-pxa2xx-pci.c does not contain BYT support yet, >so is this intentional to make it "m" now? > >> + >> +CONFIG_DW_DMAC=m >> + >Should "DW_DMAC_PCI" be added since it has been added into LTSI >patches.baytrail/1139-dma-dw-add-PCI-part-of-the-driver.patch Is that upstream as well or only LTSI? If only LTSI, then it needs to be handled special or we will get errors on the mainline configcheck. > >> +# GPIO Support >> +CONFIG_GPIOLIB=y >> +CONFIG_GPIO_SYSFS=y >Suggest to move these configs to be next to CONFIG_PINMUX. OK > > >> + >> +# PWM Support >> +CONFIG_PWM=y >The PWM for BYT driver has not been up-streamed yet. But we will want the subsystem enabled when it is, so this will be needed and doesn't break anything as is. > > >> + >> +# USB Device Support >> +CONFIG_USB_DWC3=y >> +CONFIG_USB_DWC3_GADGET=y >> +CONFIG_USB_GADGET=y >> +CONFIG_USB_LIBCOMPOSITE=m >> +CONFIG_USB_MASS_STORAGE=m >> +CONFIG_NOP_USB_XCEIV=y > >Reviewed-by: Chew Chiau Ee & Ong Boon Leong Thank you for the review! -- Darren Hart Yocto Project - Linux Kernel Intel Open Source Technology Center _______________________________________________ linux-yocto mailing list linux-yocto@yoctoproject.org https://lists.yoctoproject.org/listinfo/linux-yocto