> -----Original Message----- > From: Miroslav Lichvar [mailto:[email protected]] > Sent: Thursday, February 15, 2018 3:49 AM > To: [email protected] > Subject: [Linuxptp-devel] [PATCH] sk: turn warnings about unexpected RX filter > into debug messages. > > When a network interface doesn't support the most specific PTP filter > (e.g. it can timestamp either all or no received packets), it is > expected that the driver will report a different filter than was > requested. Turn the warnings into debug messages to avoid confusing > the users. >
Looks good to me. Would it be worth the trouble to only complain if it's an unexpected difference? I guess we would catch this as an invalid filter type that doesn't timestamp what we want... Thanks, Jake > Signed-off-by: Miroslav Lichvar <[email protected]> > --- > sk.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/sk.c b/sk.c > index 2c7593b..60415cf 100644 > --- a/sk.c > +++ b/sk.c > @@ -64,9 +64,9 @@ static int hwts_init(int fd, const char *device, int > rx_filter, int > one_step) > > if (memcmp(&cfg, &req, sizeof(cfg))) { > > - pr_warning("driver changed our HWTSTAMP options"); > - pr_warning("tx_type %d not %d", cfg.tx_type, req.tx_type); > - pr_warning("rx_filter %d not %d", cfg.rx_filter, req.rx_filter); > + pr_debug("driver changed our HWTSTAMP options"); > + pr_debug("tx_type %d not %d", cfg.tx_type, req.tx_type); > + pr_debug("rx_filter %d not %d", cfg.rx_filter, req.rx_filter); > > if (cfg.tx_type != req.tx_type || > (cfg.rx_filter != HWTSTAMP_FILTER_ALL && > -- > 2.14.3 > > > ------------------------------------------------------------------------------ > Check out the vibrant tech community on one of the world's most > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > _______________________________________________ > Linuxptp-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/linuxptp-devel ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Linuxptp-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
