Dear Bryan O'Donoghue:
Thanks for your patches! Unfortunately the Media CI robot detected some
issues:
# Test checkpatch:./0001-dt-bindings-media-Add-qcom-qcm2290-camss.patch
checkpatch
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#20:
new file mode 100644
total: 0 errors, 1 warnings, 0 checks, 243 lines checked
# Test checkpatch:./0002-media-qcom-camss-Add-support-for-TFE-Spectra-340.patch
checkpatch
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#32:
new file mode 100644
total: 0 errors, 1 warnings, 0 checks, 333 lines checked
# Test checkpatch:./0003-media-qcom-camss-Add-CSID-340-support.patch checkpatch
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#33:
new file mode 100644
total: 0 errors, 1 warnings, 0 checks, 203 lines checked
# Test
checkpatch:./0006-media-qcom-camss-Rename-camss-csid-780.c-to-camss-cs.patch
checkpatch
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#20:
.../qcom/camss/{camss-csid-780.c => camss-csid-gen3.c} | 6 +++---
total: 0 errors, 1 warnings, 0 checks, 101 lines checked
# Test
checkpatch:./0007-media-qcom-camss-Rename-camss-vfe-780.c-to-camss-vfe.patch
checkpatch
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#20:
.../qcom/camss/{camss-vfe-780.c => camss-vfe-gen3.c} | 8 ++++----
total: 0 errors, 1 warnings, 0 checks, 87 lines checked
# Test
checkpatch:./0008-media-dt-bindings-Add-qcom-sa8775p-camss-compatible.patch
checkpatch
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#32:
new file mode 100644
total: 0 errors, 1 warnings, 0 checks, 361 lines checked
# Test checkpatch:./0011-media-qcom-camss-Add-support-for-CSID-690.patch
checkpatch
CHECK: Macro argument 'csid' may be better as '(csid)' to avoid precedence
issues
#27: FILE: drivers/media/platform/qcom/camss/camss-csid-gen3.c:48:
+#define IS_CSID_690(csid)(csid->camss->res->version == CAMSS_8775P)
CHECK: Macro argument reuse 'rdi' - possible side-effects?
#49: FILE: drivers/media/platform/qcom/camss/camss-csid-gen3.c:73:
+#define CSID_RDI_CFG0(rdi)(csid_is_lite(csid) && IS_CSID_690(csid) ?\
+(0x300 + 0x100 * (rdi)) :\
+(0x500 + 0x100 * (rdi)))
CHECK: Macro argument reuse 'rdi' - possible side-effects?
#60: FILE: drivers/media/platform/qcom/camss/camss-csid-gen3.c:84:
+#define CSID_RDI_CTRL(rdi)(csid_is_lite(csid) && IS_CSID_690(csid) ?\
+(0x304 + 0x100 * (rdi)) :\
+(0x504 + 0x100 * (rdi)))
CHECK: Macro argument reuse 'rdi' - possible side-effects?
#66: FILE: drivers/media/platform/qcom/camss/camss-csid-gen3.c:89:
+#define CSID_RDI_CFG1(rdi)(csid_is_lite(csid) && IS_CSID_690(csid) ?\
+(0x310 + 0x100 * (rdi)) :\
+(0x510 + 0x100 * (rdi)))
CHECK: Macro argument reuse 'rdi' - possible side-effects?
#79: FILE: drivers/media/platform/qcom/camss/camss-csid-gen3.c:99:
+#define CSID_RDI_IRQ_SUBSAMPLE_PATTERN(rdi)(csid_is_lite(csid) &&
IS_CSID_690(csid) ?\
+(0x348 + 0x100 * (rdi)) :\
+(0x548 + 0x100 * (rdi)))
CHECK: Macro argument reuse 'rdi' - possible side-effects?
#82: FILE: drivers/media/platform/qcom/camss/camss-csid-gen3.c:102:
+#define CSID_RDI_IRQ_SUBSAMPLE_PERIOD(rdi)(csid_is_lite(csid) &&
IS_CSID_690(csid) ?\
+(0x34C + 0x100 * (rdi)) :\
+(0x54C + 0x100 * (rdi)))
total: 0 errors, 0 warnings, 6 checks, 199 lines checked
# Test checkpatch:./0012-media-qcom-camss-Add-support-for-VFE-690.patch
checkpatch
CHECK: Macro argument 'vfe' may be better as '(vfe)' to avoid precedence issues
#32: FILE: drivers/media/platform/qcom/camss/camss-vfe-gen3.c:15:
+#define IS_VFE_690(vfe) \
+ (vfe->camss->res->version == CAMSS_8775P)
CHECK: Macro argument reuse 'n' - possible side-effects?
#64: FILE: drivers/media/platform/qcom/camss/camss-vfe-gen3.c:47:
+#define RDI_WM(n)(IS_VFE_690(vfe) ? RDI_WM_690(n) : RDI_WM_780(n))
CHECK: Alignment should match open parenthesis
#114: FILE: drivers/media/platform/qcom/camss/camss-vfe-gen3.c:100:
+writel(VFE_DISABLE_DSCALING_DS4 | VFE_DISABLE_DSCALING_DS16,
+vfe->base + VFE_TOP_CORE_CFG);
total: 0 errors, 0 warnings, 3 checks, 336 lines checked
# Test
checkpatch:./0014-media-dt-bindings-Add-qcom-qcs8300-camss-compatible.patch
checkpatch
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#27:
new file mode 100644
total: 0 errors, 1 warnings, 0 checks, 336 lines checked
# Test checkpatch:./0017-media-qcom-camss-enable-csid-690-for-qcs8300.patch
checkpatch
CHECK: Macro argument reuse 'csid' - possible side-effects?
#25: FILE: drivers/media/platform/qcom/camss/camss-csid-gen3.c:48:
+#define IS_CSID_690(csid)((csid->camss->res->version == CAMSS_8775P) \
+ || (csid->camss->res->version == CAMSS_8300))
CHECK: Macro argument 'csid' may be better as '(csid)' to avoid precedence
issues
#25: FILE: drivers/media/platform/qcom/camss/camss-csid-gen3.c:48:
+#define IS_CSID_690(csid)((csid->camss->res->version == CAMSS_8775P) \
+ || (csid->camss->res->version == CAMSS_8300))
CHECK: Logical continuations should be on the previous line
#26: FILE: drivers/media/platform/qcom/camss/camss-csid-gen3.c:49:
+#define IS_CSID_690(csid)((csid->camss->res->version == CAMSS_8775P) \
+ || (csid->camss->res->version == CAMSS_8300))
total: 0 errors, 0 warnings, 3 checks, 9 lines checked
# Test checkpatch:./0018-media-qcom-camss-enable-vfe-690-for-qcs8300.patch
checkpatch
CHECK: Logical continuations should be on the previous line
#27: FILE: drivers/media/platform/qcom/camss/camss-vfe-gen3.c:17:
+ ((vfe->camss->res->version == CAMSS_8775P) \
+ || (vfe->camss->res->version == CAMSS_8300))
total: 0 errors, 0 warnings, 1 checks, 23 lines checked
Please fix your series, and upload a new version. If you have a patchwork
account, do not forget to mark the current series as Superseded.
For more details, check the full report at:
https://linux-media.pages.freedesktop.org/-/users/patchwork/-/jobs/84035407/artifacts/report.htm
.
Best regards, and Happy Hacking!
Media CI robot on behalf of the linux-media community.
---
Check the latest rules for contributing your patches at:
https://docs.kernel.org/driver-api/media/maintainer-entry-profile.html
If you believe that the CI is wrong, kindly open an issue at
https://gitlab.freedesktop.org/linux-media/media-ci/-/issues or reply-all
to this message.
