On Mon, Feb 21, 2011 at 03:36:53PM -0600, Chris Bagwell wrote: > On Mon, Feb 21, 2011 at 2:29 PM, Andrzej Giniewicz <[email protected]> wrote: > > Hi, > > > >> Looks like you have tested this patch yourself. Can you report back here > >> with your testing result and a "Tested-by" tag? I am willing to put > >> "Acked-by" once I see "Tested-by". > > > > well, indeed I tested it. About tagging, I'm not sure if this is what > > you mean, but here goes a try. If this is done somehow else, would be > > happy to do it differently, never tagged a thing here so I don't know > > the rules yet :) > > > > cheers, > > Andrzej. > > > > Tested-by: Andrzej Giniewicz <[email protected]> > > > > tested on kernel 2.6.37.1 with input-wacom 0.10.10_2 and > > xf86-input-wacom 0.10.11, tapping with single now works. > > > /***************************************************************************** > >>> diff --git a/src/wcmTouchFilter.c b/src/wcmTouchFilter.c > >>> index 793d649..093d91f 100644 > >>> --- a/src/wcmTouchFilter.c > >>> +++ b/src/wcmTouchFilter.c > >>> @@ -141,32 +141,45 @@ static void wcmFingerTapToClick(WacomDevicePtr priv) > >>> } > >>> > >>> > >>> -/* process single finger Relative mode events > >>> - * if touch is not in an active gesture mode. > >>> +/* A single finger tap is defined as 1 finger tap that lasts less than > >>> + * wcmTapTime. It results in a left button press. > >>> + * > >>> + * Some work must be done to make sure two fingers were not touching > >>> + * during this gesture. This is easy if first finger is released > >>> + * first. To handle case of second finger released first, require > >>> + * second finger to have been released before first finger ever touched. > >>> + * > >>> + * Function relies on ds[0/1].sample to be updated only when entering or > >>> + * exiting proximity so no storage is needed when initial touch occurs. > >>> */ > >>> -static void wcmFirstFingerClick(WacomCommonPtr common) > >>> +static void wcmSingleFingerTap(WacomDevicePtr priv) > >>> { > > Peter, > > I didn't put "@param priv" in comment. Seems not useful since it > includes kitchen sink and no idea what is being used in side of it. > Is there any convention to show subset of structures used? Something > like: > > @paramin priv->common->wcmChannel[] Look at Finger 1/Channel 0 and > Finger 2/Channel 1 to see current proximity and previous proximity > status.
not sure, tbh. I'm somewhat hoping that we can reduce the usage of passing priv/common etc around and simplify the functions to take only what they need. but generally, for priv and common no param tag is needed because it is the kitchen sink, as you said. what can help in some cases is something like: "requires priv->foobar to be set up" or similar but it depends much on the use-case of course. Cheers, Peter ------------------------------------------------------------------------------ Free Software Download: Index, Search & Analyze Logs and other IT data in Real-Time with Splunk. Collect, index and harness all the fast moving IT data generated by your applications, servers and devices whether physical, virtual or in the cloud. Deliver compliance at lower cost and gain new business insights. http://p.sf.net/sfu/splunk-dev2dev _______________________________________________ Linuxwacom-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
